Skip to main content

What"s the better practice: eval or append script?

Image
By User


I need to execute a custom piece of JavaScript I got from some AJAX call. I could do an eval of the string or I could just append it in a script -tag to the DOM. Which method would be better? 





var dynamicScript = 'alert(\'Hello world!\');';


Method 1 - Script : 





var x = '<script type="text/javascript">' + dynamicScript  +'</scr' + 'ipt>';

$(document.body).append(x);


Method 2 - Eval : 





eval(dynamicScript);


What method is better and why? Or is there an ever better alternative?


Source: Tips4all, CCNA FINAL EXAM
Labels:

Comments

  1. UserMay 11, 2012 at 4:47 AM

    I prefer eval, because it's generally faster than creating a script tag, and appending it (especially if you wanted to create and insert it using jQuery).

    Side note (useful application of a script tag) I also use the script-tag-insertion method: In Google Chrome's extensions, injecting script-tags is the only way to run code in the scope of a page, because the window object is sandboxed.

    PS. Notion of jQuery.getScript(). This method might be useful.

    ReplyDelete
  2. UserMay 11, 2012 at 4:47 AM

    Neither method is really that good for what you're doing. Your AJAX call should be returning data not serialized scripts. Both of your methods open you up to script injection.

    eval should be avioded at all costs. It's slow and dangerous, eval is evil

    ReplyDelete
  3. UserMay 11, 2012 at 4:47 AM

    If the ajax call is returning html with script tags, you can use $.load() to import the script.

    http://api.jquery.com/load/

    ReplyDelete

Post a Comment

Popular posts from this blog

Why is this Javascript much *slower* than its jQuery equivalent?

By User
I have a HTML list of about 500 items and a "filter" box above it. I started by using jQuery to filter the list when I typed a letter (timing code added later): $('#filter').keyup( function() { var jqStart = (new Date).getTime(); var search = $(this).val().toLowerCase(); var $list = $('ul.ablist > li'); $list.each( function() { if ( $(this).text().toLowerCase().indexOf(search) === -1 ) $(this).hide(); else $(this).show(); } ); console.log('Time: ' + ((new Date).getTime() - jqStart)); } ); However, there was a couple of seconds delay after typing each letter (particularly the first letter). So I thought it may be slightly quicker if I used plain Javascript (I read recently that jQuery's each function is particularly slow). Here's my JS equivalent: document.getElementById('filter').addEventListener( 'keyup', function () { var jsStart = (new Date).getTime()...
3 comments
Read more

Is it possible to have IF statement in an Echo statement in PHP

By User
Thanks in advance. I did look at the other questions/answers that were similar and didn't find exactly what I was looking for. I'm trying to do this, am I on the right path? echo " <div id='tabs-".$match."'> <textarea id='".$match."' name='".$match."'>". if ($COLUMN_NAME === $match) { echo $FIELD_WITH_COLUMN_NAME; } else { } ."</textarea> <script type='text/javascript'> CKEDITOR.replace( '".$match."' ); </script> </div>"; I am getting the following error message in the browser: Parse error: syntax error, unexpected T_IF Please let me know if this is the right way to go about nesting an IF statement inside an echo. Thank you.
5 comments
Read more