Skip to main content

What is wrong with my code - circularly sorted array does not show any results



I had an interview today and the person asked me this question:





How do you find easily an item in a circularly sorted array





Since I didn't know the answer, I tried to find a solution. Here's what I have:





Thanks







<?php





function searchincircularsorterlist($a, $len, $num) {

$start=0;

$end=$len-1;

$mid = 0;

while($start<$end) {

$mid=$start+$end/2;

if ($num == $a[$mid]) {

return $num;

}

if($num<$a[$mid]) {

if($num<$a[$start] && $a[$start]<=$a[$start+1])

$start=$mid++;

else

$end=$mid--;

}

else {

if($num>$a[$end] && $a[$end-1]<=$a[end])

$end=$mid--;

else

$start=$mid++;

}

}

if ($start == $end && $num == $a[$start]) {

return $num;

}

return -1;

}



$array = array(7,8,9,0,1,2,3,4,5,6);

var_dump(searchincircularsorterlist($array,sizeof($array),4));







I am trying to work with a circularly sorted array but for some reason it does not work. What's wrong with my code?


Comments

  1. 1) learn priority of operations. You should have: $mid=($start+$end)/2; which you ended up dividing $end by 2 and then $start - the result. This is why you got an infinite loop.

    2) use: $start=$mid+1; and not $start=$mid++; that will help reducing the number of loops

    <?php

    function searchincircularsorterlist($a, $len, $num) {
    $start=0;
    $end=$len-1;
    $mid = 0;
    while($start<$end) {
    $mid=($start+$end)/2;
    if ($num == $a[$mid]) {
    return $num;
    }
    if($num<$a[$mid]) {
    if($num<$a[$start] && $a[$start]<=$a[$start+1])
    $start=$mid+1;
    else
    $end=$mid-1;
    }
    else {
    if($num>$a[$end] && $a[$end-1]<=$a[end])
    $end=$mid-1;
    else
    $start=$mid+1;
    }
    }
    if ($start == $end && $num == $a[$start]) {
    return $num;
    }
    return -1;
    }

    $array = array(7,8,9,0,1,2,3,4,5,6);
    var_dump(searchincircularsorterlist($array,sizeof($array),4));

    ReplyDelete

Post a Comment

Popular posts from this blog

Why is this Javascript much *slower* than its jQuery equivalent?

I have a HTML list of about 500 items and a "filter" box above it. I started by using jQuery to filter the list when I typed a letter (timing code added later): $('#filter').keyup( function() { var jqStart = (new Date).getTime(); var search = $(this).val().toLowerCase(); var $list = $('ul.ablist > li'); $list.each( function() { if ( $(this).text().toLowerCase().indexOf(search) === -1 ) $(this).hide(); else $(this).show(); } ); console.log('Time: ' + ((new Date).getTime() - jqStart)); } ); However, there was a couple of seconds delay after typing each letter (particularly the first letter). So I thought it may be slightly quicker if I used plain Javascript (I read recently that jQuery's each function is particularly slow). Here's my JS equivalent: document.getElementById('filter').addEventListener( 'keyup', function () { var jsStart = (new Date).getTime()...

Is it possible to have IF statement in an Echo statement in PHP

Thanks in advance. I did look at the other questions/answers that were similar and didn't find exactly what I was looking for. I'm trying to do this, am I on the right path? echo " <div id='tabs-".$match."'> <textarea id='".$match."' name='".$match."'>". if ($COLUMN_NAME === $match) { echo $FIELD_WITH_COLUMN_NAME; } else { } ."</textarea> <script type='text/javascript'> CKEDITOR.replace( '".$match."' ); </script> </div>"; I am getting the following error message in the browser: Parse error: syntax error, unexpected T_IF Please let me know if this is the right way to go about nesting an IF statement inside an echo. Thank you.