Skip to main content

Bug or hack? $GLOBALS





$GLOBALS["items"] = array('one', 'two', 'three', 'four', 'five' ,'six', 'seven');

$alter = &$GLOBALS["items"]; // Comment this line

foreach($GLOBALS["items"] as $item) {

echo get_item_id();

}



function get_item_id(){

var_dump(key($GLOBALS["items"]));

}







Check output of this code, with commented and uncommented second line. My result(PHP 5.3.0). With second line







int(1) int(2) int(3) int(4) int(5) int(6) NULL







Without second line:







int(1) int(1) int(1) int(1) int(1) int(1) int(1)







Why so strange result?


Comments

  1. Here is a possible explanation:

    We know that foreach always loops over a copy of the array if it is not referenced:


    Unless the array is referenced, foreach operates on a copy of the specified array and not the array itself. foreach has some side effects on the array pointer.


    That means that the internal pointer of the original array is not changed and key() will always return the same value (as we can see when we comment out the line). And indeed if we do a var_dump($GLOBALS), we get:

    ["items"]=>
    array(7) {
    [0]=>
    string(3) "one"
    [1]=>
    string(3) "two"
    [2]=>
    string(5) "three"
    [3]=>
    string(4) "four"
    [4]=>
    string(4) "five"
    [5]=>
    string(3) "six"
    [6]=>
    string(5) "seven"
    }


    (no reference)

    But as soon as we generate a reference to the array (with $alter), $GLOBALS['items'] becomes a reference too, because both entries have to point to the same array:

    ["items"]=>
    &array(7) {
    [0]=>
    string(3) "one"
    [1]=>
    string(3) "two"
    [2]=>
    string(5) "three"
    [3]=>
    string(4) "four"
    [4]=>
    string(4) "five"
    [5]=>
    string(3) "six"
    [6]=>
    string(5) "seven"
    }
    ["alter"]=>
    &array(7) {
    [0]=>
    string(3) "one"
    [1]=>
    string(3) "two"
    [2]=>
    string(5) "three"
    [3]=>
    string(4) "four"
    [4]=>
    string(4) "five"
    [5]=>
    string(3) "six"
    [6]=>
    string(5) "seven"
    }


    Hence, the foreach loop does iterate over the original array and changes the internal pointer, which affects key().



    To sum up: It is a problem with references, not with $GLOBALS.

    ReplyDelete

Post a Comment

Popular posts from this blog

Why is this Javascript much *slower* than its jQuery equivalent?

I have a HTML list of about 500 items and a "filter" box above it. I started by using jQuery to filter the list when I typed a letter (timing code added later): $('#filter').keyup( function() { var jqStart = (new Date).getTime(); var search = $(this).val().toLowerCase(); var $list = $('ul.ablist > li'); $list.each( function() { if ( $(this).text().toLowerCase().indexOf(search) === -1 ) $(this).hide(); else $(this).show(); } ); console.log('Time: ' + ((new Date).getTime() - jqStart)); } ); However, there was a couple of seconds delay after typing each letter (particularly the first letter). So I thought it may be slightly quicker if I used plain Javascript (I read recently that jQuery's each function is particularly slow). Here's my JS equivalent: document.getElementById('filter').addEventListener( 'keyup', function () { var jsStart = (new Date).getTime()...