Skip to main content

JS Object, how to access objects from within myself



So, i see no reason why this isn't working but i am at a wall and frustrated. Why can't i call this.myself from within the wyr.message.close function? Maybe my understanding of this is scewed but i was sure this is referring to the object itself, not the function.







this.myself is undefined







Code:







wyr.message = {

myself: $('.message'),

init: function() {

if(this.myself.is(':visible')){

setTimeout(this.close, 5000);

}

},

close: function(){

this.myself.fadeOut(1200,function(){

this.myself.remove();

});

}

}




Comments

  1. wyr.message = {
    myself: $('.message'),
    init: function() {
    var self = this;
    if(this.myself.is(':visible')){
    setTimeout(function(){
    self.close();
    }, 5000);
    }
    },
    close: function(){
    this.myself.fadeOut(1200,function(){
    $(this).remove();
    });
    }
    }


    The issue is context. Within the callback function passed to fadeOut, this is bound to the element being worked on by jQuery, not to the wyr.message object.

    EDIT:

    There's also an issue with the init method. SetTimeout will bind the value of this to the global (window) object - so we save a reference to the this we want and use that to invoke the close method.

    You could also look into Function.prototype.bind, but it's not supported in older browsers.

    ReplyDelete
  2. First, javascript object literal property expressions are evaluated at the time you create the object instance. myself will be whatever that selector grabs at that time, which is probably nothing. The myself property needs to be a function if you want it to return the value of $('.message') at the time of invocation. As a consequence you'll need to change all uses to function calls as well.

    Second, during the execution of the setTimeout callback, this is bound to the window object, so you need to qualify it appropriately:

    wyr.message = {
    myself: function() { return $('.message'); },
    init: function() {
    if(this.myself().is(':visible')){
    setTimeout(this.close, 5000);
    }
    },
    close: function(){
    message.myself().fadeOut(1200,function(){
    $(this).remove();
    });
    }
    };


    (Note, this will fade out and remove everything matching the selector when the timeout fires.)

    ReplyDelete

Post a Comment

Popular posts from this blog

Why is this Javascript much *slower* than its jQuery equivalent?

I have a HTML list of about 500 items and a "filter" box above it. I started by using jQuery to filter the list when I typed a letter (timing code added later): $('#filter').keyup( function() { var jqStart = (new Date).getTime(); var search = $(this).val().toLowerCase(); var $list = $('ul.ablist > li'); $list.each( function() { if ( $(this).text().toLowerCase().indexOf(search) === -1 ) $(this).hide(); else $(this).show(); } ); console.log('Time: ' + ((new Date).getTime() - jqStart)); } ); However, there was a couple of seconds delay after typing each letter (particularly the first letter). So I thought it may be slightly quicker if I used plain Javascript (I read recently that jQuery's each function is particularly slow). Here's my JS equivalent: document.getElementById('filter').addEventListener( 'keyup', function () { var jsStart = (new Date).getTime()...

Is it possible to have IF statement in an Echo statement in PHP

Thanks in advance. I did look at the other questions/answers that were similar and didn't find exactly what I was looking for. I'm trying to do this, am I on the right path? echo " <div id='tabs-".$match."'> <textarea id='".$match."' name='".$match."'>". if ($COLUMN_NAME === $match) { echo $FIELD_WITH_COLUMN_NAME; } else { } ."</textarea> <script type='text/javascript'> CKEDITOR.replace( '".$match."' ); </script> </div>"; I am getting the following error message in the browser: Parse error: syntax error, unexpected T_IF Please let me know if this is the right way to go about nesting an IF statement inside an echo. Thank you.