Skip to main content

jquery $(selector).ready() code running even if no element was matched

Image
By User



I am using this code to only run this js on certain pages.







$("body#action_new").ready(function() {

    console.log($("body#action_new"));

    console.log($("body#action_new").length);

    console.log("code is running");

}







Even though body#action_new does not exist, the code is running.





the two console.logs print out:







[]

0

code is running







What gives?


Labels:

Comments

  1. Tips For AllFebruary 1, 2012 at 3:14 AM

    you cannot call the ready except on the document, intead you can try

    $(document).ready(function(){

    if($("#action_new").size()>0){
    console.log($("body#action_new"));
    console.log($("body#action_new").length);
    console.log("code is running");
    }

    });


    as stated by @Interrobang in the comments the .size() method internally uses .length so it is advised to use .length to avoid the additional overhead of a function call, so the above code would look like

    if($("#action_new").length )>0){

    ReplyDelete
  2. Tips For AllFebruary 1, 2012 at 3:14 AM

    You cannot call .ready() on anything but document. You will get undefined behavior in any other case.


    The .ready() method can only be called on a jQuery object matching the current document, so the selector can be omitted.


    http://api.jquery.com/ready/

    ReplyDelete

Post a Comment

Popular posts from this blog

Why is this Javascript much *slower* than its jQuery equivalent?

By User
I have a HTML list of about 500 items and a "filter" box above it. I started by using jQuery to filter the list when I typed a letter (timing code added later): $('#filter').keyup( function() { var jqStart = (new Date).getTime(); var search = $(this).val().toLowerCase(); var $list = $('ul.ablist > li'); $list.each( function() { if ( $(this).text().toLowerCase().indexOf(search) === -1 ) $(this).hide(); else $(this).show(); } ); console.log('Time: ' + ((new Date).getTime() - jqStart)); } ); However, there was a couple of seconds delay after typing each letter (particularly the first letter). So I thought it may be slightly quicker if I used plain Javascript (I read recently that jQuery's each function is particularly slow). Here's my JS equivalent: document.getElementById('filter').addEventListener( 'keyup', function () { var jsStart = (new Date).getTime()...
3 comments
Read more

Is it possible to have IF statement in an Echo statement in PHP

By User
Thanks in advance. I did look at the other questions/answers that were similar and didn't find exactly what I was looking for. I'm trying to do this, am I on the right path? echo " <div id='tabs-".$match."'> <textarea id='".$match."' name='".$match."'>". if ($COLUMN_NAME === $match) { echo $FIELD_WITH_COLUMN_NAME; } else { } ."</textarea> <script type='text/javascript'> CKEDITOR.replace( '".$match."' ); </script> </div>"; I am getting the following error message in the browser: Parse error: syntax error, unexpected T_IF Please let me know if this is the right way to go about nesting an IF statement inside an echo. Thank you.
5 comments
Read more