Skip to main content

javascript function not returning correct value



I have this function that checks a UK postcode. The problem is that it never returns true or false - only undefined .







function PostcodeAnywhere_Interactive_FindByPostcode_v1_00(Key, Postcode, UserName) {



var retval;



$.getJSON("https://services.postcodeanywhere.co.uk/PostcodeAnywhere/Interactive/FindByPostcode/v1.00/json3.ws?",

{

Key: Key,

Postcode: Postcode,

UserName: UserName

},

function (response) {

// Test for an error

if (response.Items.length == 1 && typeof(response.Items[0].Error) != "undefined") {

// Show the error message

retval = false;

} else {

// Check if there were any items found

if (response.Items.length == 0){

retval = false;

} else {

retval = true;

}

}

});



return retval;



}







To me it looks like it should always return true or false , so I can't understand where I'm going wrong. Can someone please help? Is it that the getJSON function needs time to execute?


Comments

  1. It returns undefined because $.getJSON runs asynchronously and so retval is returned before the success function of $.getJSON is executed. If you need to use retval you must call the function that uses it in the callback

    $.getJSON("https://services.postcodeanywhere.co.uk/PostcodeAnywhere/Interactive/FindByPostcode/v1.00/json3.ws?",
    {
    Key: Key,
    Postcode: Postcode,
    UserName: UserName
    },
    function (response) {
    // Test for an error
    if (response.Items.length == 1 && typeof(response.Items[0].Error) != "undefined") {
    // Show the error message
    retval = false;
    } else {
    // Check if there were any items found
    if (response.Items.length == 0){
    retval = false;
    } else {
    retval = true;
    }
    //use retval
    do_something_with_retval(retval);
    }
    });

    ReplyDelete

Post a Comment

Popular posts from this blog

Why is this Javascript much *slower* than its jQuery equivalent?

I have a HTML list of about 500 items and a "filter" box above it. I started by using jQuery to filter the list when I typed a letter (timing code added later): $('#filter').keyup( function() { var jqStart = (new Date).getTime(); var search = $(this).val().toLowerCase(); var $list = $('ul.ablist > li'); $list.each( function() { if ( $(this).text().toLowerCase().indexOf(search) === -1 ) $(this).hide(); else $(this).show(); } ); console.log('Time: ' + ((new Date).getTime() - jqStart)); } ); However, there was a couple of seconds delay after typing each letter (particularly the first letter). So I thought it may be slightly quicker if I used plain Javascript (I read recently that jQuery's each function is particularly slow). Here's my JS equivalent: document.getElementById('filter').addEventListener( 'keyup', function () { var jsStart = (new Date).getTime()...