Skip to main content

While loop not working as expected with variable

Image
By User



The following code works fine when i remove the && $f<4 , but with it in, it doesn't work.





PHP:







$titles=array();

$f=0;

while ($row=mysql_fetch_assoc($query) && $f<4){  //this line doesn't work

        $titles[]=$row['questiontitle'];

            echo "<div class='questionPreview'>$titles[$f]</div>";

            $f++;

        }




Labels:

Comments

  1. Tips For AllJanuary 30, 2012 at 2:08 AM

    If I interpret you correctly I think you are having a precedence problem. Try this:

    while (($row=mysql_fetch_assoc($query)) && ($f<4)){

    ReplyDelete
  2. Tips For AllJanuary 30, 2012 at 2:08 AM

    =has lower precedence than&&. This means that the && operator is evaluated first.

    This means that your code, in effect, looks like this:

    while ($row = (mysql_fetch_assoc($query) && $f<4)){ //this line doesn't work


    So, in other words, do the MySQL query and the comparison, and if they are both true, set $row to true; otherwise, set it to false.

    You need to use brackets to ensure that the right operations are done:

    while (($row=mysql_fetch_assoc($query)) && ($f<4)){

    ReplyDelete
  3. Tips For AllJanuary 30, 2012 at 2:08 AM

    That is probably because $row is true rather then the array:

    $ php -r 'var_dump($row = pow(2,2) && true,$row);'
    bool(true)
    bool(true)
    $ php -r 'var_dump($row = pow(2,2) && false,$row);'
    bool(false)
    bool(false)


    (pow being a random function here)

    That is because && has a higher precedence then =. As always, solve with ():

    while ( ($row = mysql_fetch_assoc($query) ) && $f<4){

    ReplyDelete

Post a Comment

Popular posts from this blog

Why is this Javascript much *slower* than its jQuery equivalent?

By User
I have a HTML list of about 500 items and a "filter" box above it. I started by using jQuery to filter the list when I typed a letter (timing code added later): $('#filter').keyup( function() { var jqStart = (new Date).getTime(); var search = $(this).val().toLowerCase(); var $list = $('ul.ablist > li'); $list.each( function() { if ( $(this).text().toLowerCase().indexOf(search) === -1 ) $(this).hide(); else $(this).show(); } ); console.log('Time: ' + ((new Date).getTime() - jqStart)); } ); However, there was a couple of seconds delay after typing each letter (particularly the first letter). So I thought it may be slightly quicker if I used plain Javascript (I read recently that jQuery's each function is particularly slow). Here's my JS equivalent: document.getElementById('filter').addEventListener( 'keyup', function () { var jsStart = (new Date).getTime()...
3 comments
Read more

Is it possible to have IF statement in an Echo statement in PHP

By User
Thanks in advance. I did look at the other questions/answers that were similar and didn't find exactly what I was looking for. I'm trying to do this, am I on the right path? echo " <div id='tabs-".$match."'> <textarea id='".$match."' name='".$match."'>". if ($COLUMN_NAME === $match) { echo $FIELD_WITH_COLUMN_NAME; } else { } ."</textarea> <script type='text/javascript'> CKEDITOR.replace( '".$match."' ); </script> </div>"; I am getting the following error message in the browser: Parse error: syntax error, unexpected T_IF Please let me know if this is the right way to go about nesting an IF statement inside an echo. Thank you.
5 comments
Read more