Skip to main content

Is a "CFRelease” needed if I am using CGImageSourceCreateWithData from a (__bridge)?



My question is very simple, I would like to know if the method "CGImageSourceCreateWithData" creates a new object copying the data I provide so that that I have to release it when I don't need it anymore, or if it just creates a reference to the data I already have so that if I release it I will lose this data (and possibly have bad access errors).





The issue is related to using (__bridge CFDataRef) as the source data. Which let's me use Core Foundation objects as toll-free in ARC mode.





Consider the following function (or method, not sure how it's called):







- (void)saveImageWithData:(NSData*)jpeg andDictionary:(NSDictionary*)dicRef andName:(NSString*)name

{

[self setCapturedImageName:name];



CGImageSourceRef source ;



// Notice here how I use __bridge

source = CGImageSourceCreateWithData((__bridge CFDataRef)jpeg, NULL);



CFStringRef UTI = CGImageSourceGetType(source);



NSMutableData *dest_data = [NSMutableData data];



// And here I use it again

CGImageDestinationRef destination = CGImageDestinationCreateWithData((__bridge CFMutableDataRef)dest_data,UTI,1,NULL);



CGImageDestinationAddImageFromSource(destination,source,0, (__bridge CFDictionaryRef) dicRef);



BOOL success = NO;

success = CGImageDestinationFinalize(destination);



if(!success) {

NSLog(@"***Could not create data from image destination ***");

}



// This only saves to the disk

NSArray *paths = NSSearchPathForDirectoriesInDomains(NSDocumentDirectory, NSUserDomainMask, YES);

NSString *documentsDirectory = [paths objectAtIndex:0]; // Get documents folder

NSString *dataPath = [documentsDirectory stringByAppendingPathComponent:@"ARPictures"];



NSError *error;

if (![[NSFileManager defaultManager] fileExistsAtPath:dataPath])

[[NSFileManager defaultManager] createDirectoryAtPath:dataPath withIntermediateDirectories:NO attributes:nil error:&error]; //Create folder



NSString *fullPath = [dataPath stringByAppendingPathComponent:[NSString stringWithFormat:@"%@.jpg", name]]; //add our image to the path



[dest_data writeToFile:fullPath atomically:YES];





self.img = [[UIImage alloc] initWithData:dest_data];

self.capturedImageData = [[NSData alloc] initWithData:dest_data];



//This is what im not sure if i should use

CFRelease(destination);

CFRelease(source);



}







My concern is about memory leaks or dealocating things I should not.





Thanks


Comments

  1. You are doing it correctly. It does not actually matter whether these routines make copies or not. What matters is that you CFRelease what you "Create" (or "Copy"). Everything here looks correct. __bridge is appropriate when passing parameters because you're not actually transferring the object from CF to Cocoa or vice versa. You're just temporarily "bridging" (casting) it.

    ReplyDelete

Post a Comment

Popular posts from this blog

[韓日関係] 首相含む大幅な内閣改造の可能性…早ければ来月10日ごろ=韓国

div not scrolling properly with slimScroll plugin

I am using the slimScroll plugin for jQuery by Piotr Rochala Which is a great plugin for nice scrollbars on most browsers but I am stuck because I am using it for a chat box and whenever the user appends new text to the boxit does scroll using the .scrollTop() method however the plugin's scrollbar doesnt scroll with it and when the user wants to look though the chat history it will start scrolling from near the top. I have made a quick demo of my situation http://jsfiddle.net/DY9CT/2/ Does anyone know how to solve this problem?

Why does this javascript based printing cause Safari to refresh the page?

The page I am working on has a javascript function executed to print parts of the page. For some reason, printing in Safari, causes the window to somehow update. I say somehow, because it does not really refresh as in reload the page, but rather it starts the "rendering" of the page from start, i.e. scroll to top, flash animations start from 0, and so forth. The effect is reproduced by this fiddle: http://jsfiddle.net/fYmnB/ Clicking the print button and finishing or cancelling a print in Safari causes the screen to "go white" for a sec, which in my real website manifests itself as something "like" a reload. While running print button with, let's say, Firefox, just opens and closes the print dialogue without affecting the fiddle page in any way. Is there something with my way of calling the browsers print method that causes this, or how can it be explained - and preferably, avoided? P.S.: On my real site the same occurs with Chrome. In the ex