Skip to main content

javascript function not returning correct value



I have this function that checks a UK postcode. The problem is that it never returns true or false - only undefined .







function PostcodeAnywhere_Interactive_FindByPostcode_v1_00(Key, Postcode, UserName) {



var retval;



$.getJSON("https://services.postcodeanywhere.co.uk/PostcodeAnywhere/Interactive/FindByPostcode/v1.00/json3.ws?",

{

Key: Key,

Postcode: Postcode,

UserName: UserName

},

function (response) {

// Test for an error

if (response.Items.length == 1 && typeof(response.Items[0].Error) != "undefined") {

// Show the error message

retval = false;

} else {

// Check if there were any items found

if (response.Items.length == 0){

retval = false;

} else {

retval = true;

}

}

});



return retval;



}







To me it looks like it should always return true or false , so I can't understand where I'm going wrong. Can someone please help? Is it that the getJSON function needs time to execute?


Comments

  1. It returns undefined because $.getJSON runs asynchronously and so retval is returned before the success function of $.getJSON is executed. If you need to use retval you must call the function that uses it in the callback

    $.getJSON("https://services.postcodeanywhere.co.uk/PostcodeAnywhere/Interactive/FindByPostcode/v1.00/json3.ws?",
    {
    Key: Key,
    Postcode: Postcode,
    UserName: UserName
    },
    function (response) {
    // Test for an error
    if (response.Items.length == 1 && typeof(response.Items[0].Error) != "undefined") {
    // Show the error message
    retval = false;
    } else {
    // Check if there were any items found
    if (response.Items.length == 0){
    retval = false;
    } else {
    retval = true;
    }
    //use retval
    do_something_with_retval(retval);
    }
    });

    ReplyDelete

Post a Comment

Popular posts from this blog

[韓日関係] 首相含む大幅な内閣改造の可能性…早ければ来月10日ごろ=韓国

div not scrolling properly with slimScroll plugin

I am using the slimScroll plugin for jQuery by Piotr Rochala Which is a great plugin for nice scrollbars on most browsers but I am stuck because I am using it for a chat box and whenever the user appends new text to the boxit does scroll using the .scrollTop() method however the plugin's scrollbar doesnt scroll with it and when the user wants to look though the chat history it will start scrolling from near the top. I have made a quick demo of my situation http://jsfiddle.net/DY9CT/2/ Does anyone know how to solve this problem?

Why does this javascript based printing cause Safari to refresh the page?

The page I am working on has a javascript function executed to print parts of the page. For some reason, printing in Safari, causes the window to somehow update. I say somehow, because it does not really refresh as in reload the page, but rather it starts the "rendering" of the page from start, i.e. scroll to top, flash animations start from 0, and so forth. The effect is reproduced by this fiddle: http://jsfiddle.net/fYmnB/ Clicking the print button and finishing or cancelling a print in Safari causes the screen to "go white" for a sec, which in my real website manifests itself as something "like" a reload. While running print button with, let's say, Firefox, just opens and closes the print dialogue without affecting the fiddle page in any way. Is there something with my way of calling the browsers print method that causes this, or how can it be explained - and preferably, avoided? P.S.: On my real site the same occurs with Chrome. In the ex